-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace hamcrest with assertj #5911
base: master
Are you sure you want to change the base?
Conversation
@fil512 I did a review of ~50 randomly chosen test files, including all contents of hapi-fhir-test-util. Some of them, particularly those that suggest switching to There are a few regarding test asserts that are always true, and some that appear to test nothing except assertj itself that I'm more interested in. This looks like it was a long haul, @fil512 @tadgh, your patience with this is laudable! |
I resolved the outstanding assertThatThrownBy() requested changes after your comments on the first few. If you find any left, they're clearly fine to resolve. |
This merge request replaces practically all usages of hamcrest with assertj.
One thing I wanted to include in this MR but was unable to was to run checkstyle on all our tests and add a checkstyle to enforce no hamcrest imports.
I also tried to remove the hamcrest jar entirely, but sadly it is currently required by awaitility. I opened a ticket a ticket with awaitility asking them if they had considered switching from hamcrest to assertj.
Some tricky cases noted here:
(1)
becomes
(2)
becomes
(3)
becomes
(4)
becomes