Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testifylint: enable empty and len rules #20869

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Mar 15, 2024

Description

Testifylint helps apply the best practices with testifylint. There are several rules and many places to modify. This help apply the empty rule and the len rule

Testing & Reproduction steps

testifylint --disable-all --enable=empty,len -fix ./...

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@mmorel-35 mmorel-35 changed the title testifylint: enable len rule testifylint: enable empty and len rules Mar 15, 2024
@mmorel-35 mmorel-35 force-pushed the testifylint/len branch 5 times, most recently from 3c17574 to bf60d19 Compare March 15, 2024 22:02
@mmorel-35 mmorel-35 marked this pull request as ready for review March 15, 2024 22:08
@mmorel-35 mmorel-35 requested a review from a team as a code owner March 15, 2024 22:08
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Copy link

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

@github-actions github-actions bot added the meta/stale Automatically flagged for inactivity by stalebot label May 21, 2024
@mmorel-35
Copy link
Contributor Author

Shall I rebase and fix conflict or will this end up in limbo ?

@github-actions github-actions bot removed the meta/stale Automatically flagged for inactivity by stalebot label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant