Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #11457: Use proxy-defaults protocol if service-defaults protocol is unset #20887

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Mongey
Copy link
Contributor

@Mongey Mongey commented Mar 21, 2024

Description

Currently if you set a proxy-default to http, and then attempt to create a service-router for a service, without the protocol set, you'll get a 500 error.

discovery chain "foo" uses a protocol "tcp" that does not permit advanced routing or splitting behavior:

See #11457 for more details.

Testing & Reproduction steps

Reproduction steps are in #11457

before:

> consul config write bug-11457/proxy-defaults.hcl;  consul config write bug-11457/service-router.hcl;  consul config write bug-11457/service-defaults.hcl

Config entry written: proxy-defaults/global
Config entry written: service-defaults/foo
Error writing config entry service-router/foo: Unexpected response code: 500 (discovery chain "foo" uses a protocol "tcp" that does not permit advanced routing or splitting behavior)

after:

> consul config write bug-11457/proxy-defaults.hcl;  consul config write bug-11457/service-router.hcl;  consul config write bug-11457/service-defaults.hcl

Config entry written: proxy-defaults/global
Config entry written: service-defaults/foo
Config entry written: service-router/foo

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant