Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

security: enable go stdlib scans #20905

Merged
merged 3 commits into from
May 23, 2024
Merged

security: enable go stdlib scans #20905

merged 3 commits into from
May 23, 2024

Conversation

dduzgun-security
Copy link
Contributor

Description

Adding configuration to support go standard librairies (stdlibs) in security-scanner at the repository and binary level.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@dduzgun-security dduzgun-security added pr/no-changelog PR does not need a corresponding .changelog entry backport-inactive/1.15 This release series is longer active. Use backport/ent/1.15. backport-inactive/1.16 This release series is no longer active backport-inactive/1.17 This release series is no longer active. Use backport/ent/1.17. backport/1.18 labels Mar 26, 2024
@dduzgun-security dduzgun-security marked this pull request as ready for review March 26, 2024 21:49
@dduzgun-security dduzgun-security requested a review from a team March 26, 2024 21:50
@dduzgun-security dduzgun-security requested a review from a team as a code owner March 26, 2024 21:50
@dduzgun-security dduzgun-security requested review from dekimsey and modrake and removed request for a team March 26, 2024 21:50
@zalimeni zalimeni added backport/ent/1.17 Changes are backported to 1.17 ent backport/ent/1.16 backport/ent/1.15 Changes are backported to 1.15 ent and removed backport-inactive/1.15 This release series is longer active. Use backport/ent/1.15. backport-inactive/1.16 This release series is no longer active backport-inactive/1.17 This release series is no longer active. Use backport/ent/1.17. labels May 23, 2024
zalimeni
zalimeni approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@zalimeni zalimeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @dduzgun-security ! TIL this new scan type. cc @sarahalsmiller

@dduzgun-security dduzgun-security merged commit 574f53d into main May 23, 2024
110 checks passed
@dduzgun-security dduzgun-security deleted the security/scan-stdlibs branch May 23, 2024 17:41
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request May 23, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zalimeni zalimeni zalimeni approved these changes

@dekimsey dekimsey Awaiting requested review from dekimsey

@modrake modrake Awaiting requested review from modrake

Assignees
No one assigned
Labels
backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.17 Changes are backported to 1.17 ent pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dduzgun-security @zalimeni