-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc Update: MaxTTL no longer capped at 24h #21066
base: main
Are you sure you want to change the base?
Conversation
Feel free to close this if there's a better way to update docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please implement the suggestions, as abbreviations like i.e. and parenthesis are style guide violations.
@@ -64,8 +64,7 @@ The corresponding CLI command is [`consul acl auth-method create`](/consul/comma | |||
[`ExpirationTime`](/consul/api-docs/acl/tokens#expirationtime) field on all tokens | |||
to a value of `Token.CreateTime + AuthMethod.MaxTokenTTL`. This field is not | |||
persisted beyond its initial use. Can be specified in the form of `"60s"` or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
persisted beyond its initial use. Can be specified in the form of `"60s"` or | |
persisted beyond its initial use. Specify time as an alphanumeric string. For example, `"60s"` and |
@@ -64,8 +64,7 @@ The corresponding CLI command is [`consul acl auth-method create`](/consul/comma | |||
[`ExpirationTime`](/consul/api-docs/acl/tokens#expirationtime) field on all tokens | |||
to a value of `Token.CreateTime + AuthMethod.MaxTokenTTL`. This field is not | |||
persisted beyond its initial use. Can be specified in the form of `"60s"` or | |||
`"5m"` (i.e., 60 seconds or 5 minutes, respectively). This value must be no | |||
smaller than 1 minute and no longer than 24 hours. Added in Consul 1.8.0. | |||
`"5m"` (i.e., 60 seconds or 5 minutes, respectively). Added in Consul 1.8.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`"5m"` (i.e., 60 seconds or 5 minutes, respectively). Added in Consul 1.8.0. | |
`"5m"` set the duration at 60 seconds and 5 minutes, respectively. Added in Consul 1.8.0. |
Description
This was uncapped in eded58b
Testing & Reproduction steps
n/a
Links
https://developer.hashicorp.com/consul/api-docs/acl/auth-methods#maxtokenttl
I don't know how the version drop down works; maybe there's a better way to do this that applies to 1.16+ docs
PR Checklist