Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: relocate Consul capacity planning page from waf/ to docs/ #21088

Merged
merged 6 commits into from
May 24, 2024

Conversation

krastin
Copy link
Contributor

@krastin krastin commented May 13, 2024

Description

Do not merge until the following related PR is approved and ready for merge:
https://github.com/hashicorp/tutorials/pull/2091

Moving the Consul capacity planning page from WAF/ to docs/ in the shape of an Overview template page.

Testing & Reproduction steps

None

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@krastin krastin added type/docs Documentation needs to be created/updated/clarified pr/no-changelog PR does not need a corresponding .changelog entry pr/no-metrics-test backport-inactive/1.16 This release series is no longer active backport-inactive/1.17 This release series is no longer active. Use backport/ent/1.17. backport/1.18 labels May 13, 2024
@krastin krastin self-assigned this May 13, 2024
@krastin krastin requested a review from a team as a code owner May 13, 2024 12:52
@krastin krastin added the pr/do-not-merge PR cannot be merged in its current form. label May 13, 2024
Copy link
Contributor

@boruszak boruszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work converting this page using our content templates as a guide.

Please implement the suggested changes and then read through the page again. Then I'll review again for final approval.

website/content/docs/architecture/capacity-planning.mdx Outdated Show resolved Hide resolved
website/content/docs/architecture/capacity-planning.mdx Outdated Show resolved Hide resolved
website/content/docs/architecture/capacity-planning.mdx Outdated Show resolved Hide resolved
website/content/docs/architecture/capacity-planning.mdx Outdated Show resolved Hide resolved
website/content/docs/architecture/capacity-planning.mdx Outdated Show resolved Hide resolved
website/content/docs/architecture/capacity-planning.mdx Outdated Show resolved Hide resolved
website/content/docs/architecture/capacity-planning.mdx Outdated Show resolved Hide resolved
website/content/docs/architecture/capacity-planning.mdx Outdated Show resolved Hide resolved
website/content/docs/architecture/capacity-planning.mdx Outdated Show resolved Hide resolved
website/content/docs/architecture/capacity-planning.mdx Outdated Show resolved Hide resolved
Copy link

@cjobermaier cjobermaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve once @boruszak suggestions are added.

Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>
@krastin krastin removed the pr/do-not-merge PR cannot be merged in its current form. label May 21, 2024
@boruszak boruszak removed backport-inactive/1.16 This release series is no longer active backport-inactive/1.17 This release series is no longer active. Use backport/ent/1.17. labels May 21, 2024
Copy link
Contributor

@boruszak boruszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really excellent work.

I left suggestions to correct typos and other style issues. The only thing that's not a suggestion to accept is my comment about using code font and linking out for the lists of metrics.

Approving so you're not blocked.

website/content/docs/architecture/capacity-planning.mdx Outdated Show resolved Hide resolved
website/content/docs/architecture/capacity-planning.mdx Outdated Show resolved Hide resolved
website/content/docs/architecture/capacity-planning.mdx Outdated Show resolved Hide resolved
website/content/docs/architecture/capacity-planning.mdx Outdated Show resolved Hide resolved
website/content/docs/architecture/capacity-planning.mdx Outdated Show resolved Hide resolved
website/content/docs/architecture/capacity-planning.mdx Outdated Show resolved Hide resolved
website/content/docs/architecture/capacity-planning.mdx Outdated Show resolved Hide resolved
website/content/docs/architecture/capacity-planning.mdx Outdated Show resolved Hide resolved
website/content/docs/architecture/capacity-planning.mdx Outdated Show resolved Hide resolved
website/content/docs/architecture/capacity-planning.mdx Outdated Show resolved Hide resolved
Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>
@krastin krastin merged commit 912c5f5 into main May 24, 2024
61 checks passed
@krastin krastin deleted the docs/krastin/waf-capacityplan branch May 24, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-changelog PR does not need a corresponding .changelog entry pr/no-metrics-test type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants