Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Well Architected Framework content migration #21099

Merged

Conversation

boruszak
Copy link
Contributor

Description

Migrates content from the Well Architected Framework documentation set to the Consul documentation set.

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@boruszak boruszak added type/docs Documentation needs to be created/updated/clarified pr/no-changelog PR does not need a corresponding .changelog entry backport/1.18 labels May 13, 2024
@boruszak boruszak requested a review from a team as a code owner May 13, 2024 23:29
Comment on lines 1265 to 1266
"title": "Monitor service communication",
"path": "agent/monitor/service"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is an intuitive place for it if we're centering around jobs to be done, but ok if this is a temp measure

These are usually two different personas:

  • Consul operator monitoring Consul itself
  • Service operator/developer monitoring the services on Consul

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a temp place, with the only req from me is that they all go in the same location (for now anyway).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other option is to place it in /connect/observability. It's an easy enough fix before merging...@cjobermaier is it critical that they're all in the same location? Happy to go either way, with the temp location or splitting them into two locations.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's easier to discover, splitting into two locations is probably fine, especially since we will have redirects sending people who bookmarked it during the first publication.

@boruszak boruszak merged commit 1c0f6e5 into main May 20, 2024
61 checks passed
@boruszak boruszak deleted the docs/WAF-212-Content-Migration-Migrate-Consul-monitoring-docs branch May 20, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants