-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc added for Version specific upgrade Consul on Kubernetes components #21101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question before I approve - does the recommendation apply when ports.grpc_tls
is set to 8503
? It's unclear in the existing sentence whether the instruction applies when the field is disabled (set to -1
), or if the recommendation applies when the port is assigned to a value that is not the default (8503
).
Hi Jeff,
Recommendation applies when instead of ports.grpc, `ports.grpc_tls` is
used.
Thanks,
Sujata
…On Tue, May 14, 2024 at 10:47 AM Jeff Boruszak ***@***.***> wrote:
***@***.**** commented on this pull request.
Question before I approve - does the recommendation apply when
ports.grpc_tls is set to 8503? It's unclear in the existing sentence
whether the instruction applies when the field is disabled (set to -1),
or if the recommendation applies when the port is assigned to a value that
is not the default (8503).
------------------------------
In website/content/docs/k8s/upgrade/index.mdx
<#21101 (comment)>:
> @@ -15,6 +15,8 @@ As of Consul v1.14.0 and the corresponding Helm chart version v1.0.0, Kubernetes
The v1.0.0 release of the Consul on Kubernetes Helm chart also introduced a change to the [`externalServers[].hosts` parameter](/consul/docs/k8s/helm#v-externalservers-hosts). Previously, you were able to enter a provider lookup as a string in this field. Now, you must include `exec=` at the start of a string containing a provider lookup. Otherwise, the string is treated as a DNS name. Refer to the [`go-netaddrs`](https://github.com/hashicorp/go-netaddrs) library and command line tool for more information.
+When upgrading to v1.0.0 or higher, in the multi datacenter use case, where the servers are running outside of Kubernetes and in the gRPC TLS configuration ports.grpc_tls is set, then the externalServers.tlsServerName need to be set to server.<datacenter>.domain
⬇️ Suggested change
-When upgrading to v1.0.0 or higher, in the multi datacenter use case, where the servers are running outside of Kubernetes and in the gRPC TLS configuration ports.grpc_tls is set, then the externalServers.tlsServerName need to be set to server.<datacenter>.domain
+When upgrading a multi-datacenter deployment that has Consul servers running outside of the Kubernetes cluster to v1.0.0 or higher, set [`externalServers.tlsServerName`](/consul/docs/k8s/helm#v-externalservers-tlsservername) to `server.<primary-datacenter>.domain` when [`ports.grpc_tls`](/consul/docs/agent/config/config-files#grpc_tls_port) is configured on the Consul agent.
—
Reply to this email directly, view it on GitHub
<#21101 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOSX776LYDB4M2NV4OHMS53ZCJEZ3AVCNFSM6AAAAABHVHXZ3GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJWGA2DMMZTG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Thanks,
Sujata Roy
Sr. Engineer II- Backline Consul
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated my suggestion based on your response. Please implement it (I think it should fix the deployment preview error once you do.
Approving to unblock you!
Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>
Fixed the link of grpc ports
#21101) * Added upgrade instruction - NET-4882 * Update website/content/docs/k8s/upgrade/index.mdx Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com> * Update index.mdx Fixed the link of grpc ports --------- Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>
…es components into release/1.18.x (#21146) * backport of commit eaaf869 * Doc added for Version specific upgrade Consul on Kubernetes components (#21101) * Added upgrade instruction - NET-4882 * Update website/content/docs/k8s/upgrade/index.mdx Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com> * Update index.mdx Fixed the link of grpc ports --------- Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com> --------- Co-authored-by: Sujata Roy <sujata@hashicorp.com> Co-authored-by: Sujata Roy <61177855+20sr20@users.noreply.github.com> Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>
Description
Customer upgraded from 0.49 chart to 1.0.0 and also to 1.1.0. They are running consul servers on VMs outside Consul Client EKS in Secondary DC and have externalServers.tlsServerName unset(which is null by default) in regards to 0.49.5 chart. However, upon upgrade and making changes of ports.grpc to ports.grpc_tls, they started to see following error of TRANSIENT_FAILURE across multiple PODs
Testing & Reproduction steps
externalServers.tlsServerName = null
Links
https://hashicorp.atlassian.net/browse/NET-4882
PR Checklist