Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc added for Version specific upgrade Consul on Kubernetes components #21101

Merged
merged 5 commits into from
May 20, 2024

Conversation

20sr20
Copy link
Contributor

@20sr20 20sr20 commented May 14, 2024

Description

Customer upgraded from 0.49 chart to 1.0.0 and also to 1.1.0. They are running consul servers on VMs outside Consul Client EKS in Secondary DC and have externalServers.tlsServerName unset(which is null by default) in regards to 0.49.5 chart. However, upon upgrade and making changes of ports.grpc to ports.grpc_tls, they started to see following error of TRANSIENT_FAILURE across multiple PODs

Testing & Reproduction steps

  1. Make changes to gRPC TLS configuration to replace ports.grpc with ports.grpc_tls
  2. Perform an upgrading from helm chart 0.49.0 to 1.0.0, add following line in values.yaml
    externalServers.tlsServerName = null

Links

https://hashicorp.atlassian.net/browse/NET-4882

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@20sr20 20sr20 added the type/docs Documentation needs to be created/updated/clarified label May 14, 2024
@20sr20 20sr20 requested a review from a team as a code owner May 14, 2024 01:55
@20sr20 20sr20 changed the title Doc-PR-NET-4882 Doc added for Version specific upgrade Consul on Kubernetes components May 14, 2024
@20sr20 20sr20 requested a review from boruszak May 14, 2024 01:59
Copy link
Contributor

@boruszak boruszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question before I approve - does the recommendation apply when ports.grpc_tls is set to 8503? It's unclear in the existing sentence whether the instruction applies when the field is disabled (set to -1), or if the recommendation applies when the port is assigned to a value that is not the default (8503).

website/content/docs/k8s/upgrade/index.mdx Outdated Show resolved Hide resolved
@20sr20
Copy link
Contributor Author

20sr20 commented May 14, 2024 via email

@boruszak boruszak added pr/no-changelog PR does not need a corresponding .changelog entry backport/1.18 labels May 16, 2024
@boruszak boruszak self-requested a review May 16, 2024 17:51
Copy link
Contributor

@boruszak boruszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated my suggestion based on your response. Please implement it (I think it should fix the deployment preview error once you do.

Approving to unblock you!

20sr20 and others added 2 commits May 20, 2024 15:15
Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>
Fixed the link of grpc ports
@boruszak boruszak merged commit 943f007 into main May 20, 2024
61 checks passed
@boruszak boruszak deleted the Doc-PR-NET-4882 branch May 20, 2024 23:05
boruszak added a commit that referenced this pull request May 20, 2024
#21101)

* Added upgrade instruction - NET-4882

* Update website/content/docs/k8s/upgrade/index.mdx

Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>

* Update index.mdx

Fixed the link of grpc ports

---------

Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>
boruszak added a commit that referenced this pull request May 20, 2024
…es components into release/1.18.x (#21146)

* backport of commit eaaf869

* Doc added for Version specific upgrade Consul on Kubernetes components (#21101)

* Added upgrade instruction - NET-4882

* Update website/content/docs/k8s/upgrade/index.mdx

Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>

* Update index.mdx

Fixed the link of grpc ports

---------

Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>

---------

Co-authored-by: Sujata Roy <sujata@hashicorp.com>
Co-authored-by: Sujata Roy <61177855+20sr20@users.noreply.github.com>
Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>
@20sr20 20sr20 self-assigned this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants