-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow vendor class to be used without FIFO. #2450
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can use existing CFG_TUD_VENDOR_RX_BUFSIZE
when not defined or defined to 0 mean no buffered. https://github.com/hathach/tinyusb/blob/master/examples/device/webusb_serial/src/tusb_config.h#L104-L105
I am off for TET holidays for a couple of weeks. Will try to review afterwards, thank you for your patient.
That's true. Me too I was back to China for holidays:) |
Have a great year of 🐉 |
@hathach Done |
@kkitayam Didn't see that you've already done it :) |
Describe the PR
Currently vendor class manage data the same way as CDC class.
Many protocols using buck transfer are based on packets but not data stream like CDC.
In these cases a FIFO is not needed which adds overhead, also putting all packets in FIFO adds extra difficulty to separate them since length of each packet is lost.
Additional context
I'm trying to make a CMSIS-DAP dongle.