Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle relative symlinks on write #10790

Merged
merged 1 commit into from
May 20, 2024
Merged

Handle relative symlinks on write #10790

merged 1 commit into from
May 20, 2024

Conversation

kirawi
Copy link
Member

@kirawi kirawi commented May 18, 2024

Resolves #10732

@kirawi kirawi added C-bug Category: This is a bug A-helix-term Area: Helix term improvements labels May 18, 2024
@kirawi kirawi force-pushed the symlink branch 2 times, most recently from 8510918 to 3177b5f Compare May 18, 2024 14:14
pascalkuthe
pascalkuthe previously approved these changes May 18, 2024
View reviewed changes
Copy link
Member

@pascalkuthe pascalkuthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great to have this edgecases covered with a test for it too !

@kirawi

This comment was marked as resolved.

Sign in to view
@archseer archseer merged commit 5b9f5f9 into helix-editor:master May 20, 2024
6 checks passed
@kirawi kirawi deleted the symlink branch May 21, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalkuthe pascalkuthe pascalkuthe approved these changes

Assignees
No one assigned
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fails to write files that are relative symlinks that don't resolve from cwd
3 participants
@kirawi @pascalkuthe @archseer