Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
it seems that
manifestFile.apis
is a write-only field, and can safely be removed.Special notes for your reviewer:
The
Capabilities.APIVersions
field, while no longer used on its own by the Helm code directly, remains exposed to helm charts as part of the.Capabilities
struct, which may well depend on it, so it must stay untouched.Introducing new versions of functions with one less argument seems like an overkill, so I just replaced the argument names with an underscore.
If applicable: