-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added multi-platform plugin hook support #12962
base: main
Are you sure you want to change the base?
Conversation
1a5d6c7
to
d8b46cc
Compare
@sabre1041 could you or one of the other maintainers please take a look at this? |
I've started to take a look. Will add some further thoughts in the next day or so |
@sabre1041 have you been able to find any time to look at this? And if so is there any feedback? |
getting back up to speed after a work conference. will review this week |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified in Linux/OSX environments. Will try to find a Windows box to test against this week
@stevehipwell Receiving the following error on windows when installing a plugin:
Not receiving the same error with the latest helm release |
@sabre1041 the error should be consistent, but not necessarily identical, to the existing behaviour on Windows. Basically no currently published Helm plugins can support Windows (unless they have no hooks) so the install script should still fail with the new code. |
Contents of PR causes an error while the released code completes successfully. Tested using the helm diff plugin |
@sabre1041 I'm getting the exact same error for both the published code and the code on this branch using my Windows machine. helm plugin install https://github.com/databus23/helm-diff
Error: exec: "sh": executable file not found in %PATH% Has the Windows machine you're currently testing on been configured to support |
d8b46cc
to
b2caabd
Compare
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
b2caabd
to
c5d9313
Compare
@sabre1041 this should now keep the current behaviour on Windows machines which can run |
What this PR does / why we need it:
This PR addresses #7117 to allow plugin installation on Windows in a backwards compatible way. It also adds better OS specific hook support and improved platform command logic to support args containing a space.
Special notes for your reviewer:
Is there guidance for updating the documentation as AFAIK it's in a separate repo?
If applicable: