Allow repotest OCI server to bind to localhost #12978
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This adds a
repotest.NewOCIServerWithBindAddress
function for building an OCI server that binds to a specific address, eg.The current
repotest.NewOCIServer
function binds to an empty address, which means binding to all interfaces. This gets annoying when locally running tests that use repotest, as the Macos firewall dialog box will pop up every time you run tests.I figured it would technically be backwards incompatible to just change
repotest.NewOCIServer
to bind to localhost instead of all interfaces, so I decided to split that out into a separate function. I assume most people probably don't rely on exposing the repotest server outside localhost (especially since the returnedRegistryURL
is for localhost), but someone could conceivably be depending on that.Special notes for your reviewer:
I didn't see any test coverage for this function, so I'll probably need to write that if you think this change is a good idea.
If applicable: