-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump oras minor version #12998
bump oras minor version #12998
Conversation
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AustinAbro321 can you resolve the conflict?
@sabre1041 done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scottrigby @sabre1041 Do you think you could get this into v3.15.2? It would solve a relatively big bug for my team and I |
What this PR does / why we need it:
This is a minor update to the oras version while we wait for the major oras v2 upgrade. This update matters because the current auth mechanism in oras breaks when logging into an insecure repo unless an IP address is used. Oras v1.2.5 updates to use docker v25.0.1 for auth mechanisms which avoids this issue
Special notes for your reviewer:
I can give the whole stack trace is wanted, but ultimately it boils down ORAS v1.2.4 calling functions which eventually use this faulty regex to determine if the domain is correct https://github.com/distribution/distribution/blob/v2.8.3/reference/regexp_deprecated.go#L12-L23
If applicable: