-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE-9507: ADD application/gzip,application/octet-stream
accept header
#13034
base: main
Are you sure you want to change the base?
Conversation
…ader when downloading chart Signed-off-by: Matt Clegg <m@cle.gg>
So, I will ask the question where are the test for this? |
Signed-off-by: Matt Clegg <m@cle.gg>
OK, @robertsirc
or did you have something else in mind? You may also test with a private repository on GitHub via;
which returns;
but
downloads the asset. |
Like in |
Thanks for clarifying @robertsirc |
@mattclegg yes is this in one PR or two? |
@robertsirc The other PRs are to avoid having noise on this branch for other tests that aren't needed. I've merged the test for the server with varied Accept Header to this branch. Please let me know if there's anything else that needs to be done before this PR can be merged. |
What this PR does:
This PR adds the accept header to the request sent by the HTTPGetter when downloading archives.
The function accepts gzip and so it would be preferable if it also notified the server about this. Additionally, this adds support for private helm charts hosted with GitHub.
Special notes for your reviewer:
Issue related to this are #9507