fuse: provide header and payloads separately #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cagatay-y
force-pushed
the
too-virtq-too-refactor
branch
2 times, most recently
from
774226b
to
0983742
Compare
cagatay-y
changed the title
cagatay-y
force-pushed
the
too-virtq-too-refactor
branch
from
0983742
to
ad86ce0
Compare
|
813ad43 does not really fit into the theme of this PR as originally the branch was intended to be a more general Virtio work and only later I realized the parts related to FUSE can be merged independently. I can remove the commit, if you prefer. |
cagatay-y
force-pushed
the
too-virtq-too-refactor
branch
2 times, most recently
from
22191a0
to
bd43cf2
Compare
Remove the functionality in prep_transfer_from_raw for splitting a single buffer into multiple descriptors, as it does not have an advantage and complicates the method quite a bit.
Match cases made out of combinations cause a lot of code duplication.
This will allow providing transfer data that has an unsized field as a pair of sized and unsized objects, rather than having to create the whole transfer as a dynamically-sized object, as is the case in virtiofs.
Virtio allows a single transfer to be split into multiple buffers. Using this functionality, we can provide the header and the payload in FUSE requests separately. This in turn allows us to avoid the unsafe operations associated with dynamically-sized object creation.
cagatay-y
force-pushed
the
too-virtq-too-refactor
branch
from
bd43cf2
to
95c98e9
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providing headers and payloads separately allows us to avoid the complexity associated with dynamically-sized types and in some cases copying.