Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(jsdoc): Secure Headers Middleware #2704

Conversation

goisaki
Copy link
Contributor

@goisaki goisaki commented May 18, 2024

This PR is to add JSDoc for Secure Headers Middleware.
Note that the target of the PR is not main.

Related:

@goisaki goisaki mentioned this pull request May 18, 2024
16 tasks
@goisaki
Copy link
Contributor Author

goisaki commented May 19, 2024

Same problem:

Hi @yusukebe
Currently, the change to remove Partial is made only in JSDoc. To include these changes in the code, we need to merge honojs:main into honojs:docs/jsdoc-middleware.

(It is possible to do this merge in this PR, but it is not recommended because it will include out-of-scope changes.)

Originally posted by @goisaki in #2703 (comment)

@yusukebe
Copy link
Member

Hey @goisaki

I've updated this PR/branch by myself. It's ready to merge! Go!

@yusukebe yusukebe merged commit 79f860e into honojs:docs/jsdoc-middleware May 22, 2024
yusukebe added a commit that referenced this pull request May 24, 2024
Co-authored-by: Yusuke Wada <yusuke@kamawada.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants