Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] fix for loading after_scheduler state #5120

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

imgaojun
Copy link
Contributor

馃搶 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

馃毃 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

related issue #5119

馃摑 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

I have introduced a new method, load_state_dict, in the Scheduler class in colossalai/nn/lr_scheduler/delayed.py. This method enhances the scheduler's ability to reinstate its state, specifically focusing on the after_scheduler component. The key changes include:

Updating the Scheduler class with the load_state_dict method.
Ensuring the after_scheduler's state is appropriately loaded from the provided state dictionary if the after_scheduler_dict key is present.

馃挜 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

猸愶笍 Do you enjoy contributing to Colossal-AI?

  • 馃対 Yes, I do.
  • 馃寶 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@imgaojun imgaojun requested a review from a team as a code owner November 28, 2023 03:38
Copy link
Contributor

github-actions bot commented Dec 5, 2023

The code coverage for the changed files is 39%.

Click me to view the complete report
Name                                    Stmts   Miss  Cover
-----------------------------------------------------------
colossalai/nn/lr_scheduler/delayed.py     125     76    39%
-----------------------------------------------------------
TOTAL                                     125     76    39%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant