Allow certificate inspection on policy signature verification (including fulcio extensions) #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulcio) Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
|
lgtm! |
colek42
approved these changes
May 13, 2024
| @@ -89,9 +89,12 @@ type RunResult struct { | |||
| // Deprecated: Use RunWithExports instead | |||
| func Run(stepName string, opts ...RunOption) (RunResult, error) { | |||
| results, err := run(stepName, opts) | |||
| if len(results) > 1 { | |||
| if len(results) == 0 { | |||
jkjell
approved these changes
May 13, 2024
matglas
pushed a commit
to matglas/go-witness
that referenced
this pull request
May 14, 2024
…ing fulcio extensions) (in-toto#246) allow certificate inspection on policy signature verification (including fulcio) Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> Signed-off-by: Matthias Glastra <matglas.git@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are necessary to fully enable in-toto/witness#353 to work. Also note that this PR contains a fix for a panic in the case of a
[]RunResultof length 0 (implying an error) getting returned fromRun.