refactor: make all run options have shorthand vars #441
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for witness-project canceled.
|
Simple nitpick refactor to have all run option flags have shorthand vars.
DataDavD
force-pushed
the
ddansby/refactor/NOISSUE/make-run-options-all-be-TypeVarP-flags
branch
from
a23868a
to
5e96483
Compare
|
fyi forced pushed the rebase converting ts var to u (forgot to change that before pushing original 😅 ), so docgen step would need to be rerun. |
jkjell
reviewed
May 7, 2024
| cmd.Flags().BoolVar(&ro.Tracing, "trace", false, "Enable tracing for the command") | ||
| cmd.Flags().StringSliceVar(&ro.TimestampServers, "timestamp-servers", []string{}, "Timestamp Authority Servers to use when signing envelope") | ||
| cmd.Flags().BoolVarP(&ro.Tracing, "trace", "t", false, "Enable tracing for the command") | ||
| cmd.Flags().StringSliceVarP(&ro.TimestampServers, "timestamp-servers", "u", []string{}, "Timestamp Authority Servers to use when signing envelope") |
There was a problem hiding this comment.
I'm not a huge fan with u as the short-hand for TSA but, t is the only thing that makes sense for tracing... 😅. @ChaosInTheCRD or @mikhailswift either of you have a good suggestion?
There was a problem hiding this comment.
Completely agree @jkjell. I wasn't sure what else to use tbh, because as you noted t was already used aptly for tracing, as is s for StepName.
Maybe a for Authority?
Let me know what y'all think. I can also understand if y'all believe some of these actually should not have single shorthand letter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor: Simple nitpick refactor to have all run option flags have shorthand vars.
Description
I was looking at my old PR that added hashes as run options flags and realized it and others did not have shorthand vars like the majority of the run options flags. So, I threw this nit PR up just in case y'all believe its best to align and have all run options flags have shorthand vars.
Feel free to close PR if you don't agree.