[WIP] Add support to read lincence from secret #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viveksyngh
force-pushed
the
secret-support-for-license
branch
2 times, most recently
from
45bf73d
to
d8388fb
Compare
This commit add support to take licence from a kubernetes secret. A kubernetes secret can be created, which can be passed through helm chart. Previous flag is still present to provide backward comptability. Signed-off-by: Vivek Singh <vivekkmr45@yahoo.in>
viveksyngh
force-pushed
the
secret-support-for-license
branch
from
d8388fb
to
33f9ea7
Compare
|
Could you replace |
|
alexellis
reviewed
Sep 15, 2021
| @@ -58,6 +58,13 @@ spec: | |||
| env: | |||
| - name: client_image | |||
| value: "{{.Values.clientImage}}" | |||
| {{- if and .Values.proLicenseSecret.name .Values.proLicenseSecret.key }} | |||
| - name: LICENSE | |||
There was a problem hiding this comment.
Please could we mount the secret instead for consistency between the projects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit add support to take licence from a kubernetes secret.
A kubernetes secret can be created, which can be passed through helm chart.
Previous flag is still present to provide backward comptability.
Signed-off-by: Vivek Singh vivekkmr45@yahoo.in
#67
Description
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have:
git commit -s