Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mesh config to not import k8s libraries #51041

Merged
merged 1 commit into from
May 23, 2024
Merged

Update mesh config to not import k8s libraries #51041

merged 1 commit into from
May 23, 2024

Conversation

howardjohn
Copy link
Member

Depends on istio/api#3154

@istio-testing
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@istio-testing istio-testing added do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 14, 2024
@howardjohn howardjohn mentioned this pull request May 14, 2024
Merged
@howardjohn
Copy link
Member Author

/test all

@howardjohn
Copy link
Member Author

/test all

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label May 15, 2024
@howardjohn howardjohn marked this pull request as ready for review May 22, 2024 15:28
@istio-testing istio-testing removed do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. needs-rebase Indicates a PR needs to be rebased before being merged labels May 22, 2024
@howardjohn howardjohn added the release-notes-none Indicates a PR that does not require release notes. label May 22, 2024
@howardjohn
Copy link
Member Author

/retest

kyessenov
kyessenov approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@kyessenov kyessenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@howardjohn
Copy link
Member Author

/retest

@istio-testing istio-testing merged commit 7f33ec2 into istio:master May 23, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyessenov kyessenov kyessenov approved these changes

@ericvn ericvn ericvn approved these changes

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@costinm costinm Awaiting requested review from costinm costinm is a code owner

@linsun linsun Awaiting requested review from linsun linsun is a code owner

@stevenctl stevenctl Awaiting requested review from stevenctl stevenctl is a code owner

Assignees

@kyessenov kyessenov

Labels
release-notes-none Indicates a PR that does not require release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@howardjohn @istio-testing @kyessenov @ericvn @hzxuzhonghu