Remove deadcode: Interface TokenExchanger, and only implementation (Google STS) #51043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardjohn
added
the
release-notes-none
istio-testing
added
the
size/L
kyessenov
reviewed
May 14, 2024
zirain
approved these changes
May 15, 2024
11 tasks
kyessenov
reviewed
May 16, 2024
| // TODO extract this logic out to a plugin | ||
| if o.CAProviderName == security.GoogleCAProvider || o.CAProviderName == security.GoogleCASProvider { | ||
| var err error | ||
| o.TokenExchanger, err = stsclient.NewSecureTokenServiceExchanger(o.CredFetcher, o.TrustDomain) |
There was a problem hiding this comment.
Is CredFetcher used anywhere else besides STS?
There was a problem hiding this comment.
Yeah that allows GCE auth which can be used agent and Istiod I believe. not sure the implementation was ever really completed though...
It was intended for VMs, not Google specific (i.e. there could be an AWS/EC2 one, just no one wrote it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup from #50989