Moved BaseHolder and Source to core ee #11744
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbartel
requested changes
May 3, 2024
| * @param <T> the type of holder | ||
| */ | ||
| @ManagedObject("Holder - a container for servlets and the like") | ||
| public abstract class ServletContextHolder<T> extends BaseHolder<T> |
There was a problem hiding this comment.
I think this name is misleading: it is not holding a ServletContext. Not sure of what a better name might be? ServletContextScopedHolder?
| return new UnavailableException(message); | ||
| } | ||
|
|
||
| @ManagedAttribute(value = "Display Name", readonly = true) |
There was a problem hiding this comment.
Can't all the methods from here on down be pushed down into BaseHolder? They're independent of the servlet spec version, and I don't think its important if they are not used by some of the derived classes.
lorban
reviewed
May 3, 2024
|
I'll close this soon, but I'll first look through for any worthwhile cleanups in the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a lot of work just to move 2 small classes to core.
We have to evaluate if the reduced duplication is worth the complexity of the split.
Note that I have not yet updated the EE10 code to use these common classes, will be the same changes as made to EE11