Issue #11745 - fix the environment var for the GAE Instance in id-manager.xml #11797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ager.xml Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
…ager.xml Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
janbartel
approved these changes
May 16, 2024
…11745-sessionIdManagerWorkerName
|
@lachlan-roberts I think you should merge this - the build failure is something to do with flakey mongo test. |
|
@janbartel I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #11745
The
GAE_MODULE_INSTANCEdoesn't seem to be available anymore for AppEngine.The GAE documentation says that the
GAE_INSTANCEenv var contains "the ID of the instance on which your service is currently running" (see https://cloud.google.com/appengine/docs/standard/java-gen2/runtime#environment_variables).Also the jetty-runtime image for GAE Flexible uses the
GAE_INSTANCEenv var for this purpose (see https://github.com/GoogleCloudPlatform/jetty-runtime/blob/248859491c1df0f8675bb4ee1252225b0f53c6ce/jetty9/src/main/docker/50-jetty.bash#L4-L7).