Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

991 #1031

Open
wants to merge 3 commits into
base: v1.x
Choose a base branch
from
Open

991 #1031

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions include/cnl/rounding_integer.h
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,16 @@ namespace cnl {
scale<Digits, Radix, Rep>{}(_impl::to_rep(s)));
}
};

template<int Digits, int Radix, class Rep, class RoundingTag>
struct scale<Digits, Radix, _impl::number<Rep, RoundingTag>,
_impl::enable_if_t<Digits < 0 && _impl::is_rounding_tag<RoundingTag>::value>> {
CNL_NODISCARD constexpr auto operator()(_impl::number<Rep, RoundingTag> const& s) const
-> decltype(s/_impl::power_value<Rep, -Digits, Radix>())
{
return s/_impl::power_value<Rep, -Digits, Radix>();
}
};

////////////////////////////////////////////////////////////////////////////////
// cnl::set_rep<rounding_integer, Rep>
Expand Down
53 changes: 53 additions & 0 deletions test/unit/scaled_integer/rounding/rounding_scaled_integer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -82,4 +82,57 @@ namespace {
static_assert(identical(dest_type{0}, dest_type{source_type{.75}}), "");
static_assert(identical(dest_type{1}, dest_type{source_type{1.}}), "");
}

TEST(rounding_scaled_integer, 991)
{
using DecX = cnl::scaled_integer<cnl::rounding_integer<long long>, cnl::power<-1, 100>>;
DecX num1 = 10.554;
DecX num2 = 10.545;
std::cout<<num1<<" "<<num2<<std::endl;
}

TEST(rounding_scaled_integer, 991AssignTest)
{
using DecX_2 = cnl::scaled_integer<cnl::rounding_integer<long long>, cnl::power<-2, 10>>;
using DecX_4 = cnl::scaled_integer<cnl::rounding_integer<long long>, cnl::power<-4, 10>>;

DecX_2 n1 = 10.0151;
DecX_2 n2 = 10.0249;
EXPECT_EQ(n1, n2); // 10.02

int64_t xn = (int64_t)n1;
double xm = (double)n2;
EXPECT_EQ(xn, 10);
EXPECT_DOUBLE_EQ(xm, 10.02);

static_assert(std::is_same_v<decltype(n1*n2), DecX_4>);
EXPECT_EQ(n1*n2, DecX_4{100.4004});
EXPECT_DOUBLE_EQ((double)(n1*n2), 100.4004);

n1 += 0.6;
EXPECT_EQ((int)n1, 11);

n1 += 0.38;
EXPECT_EQ(n1, 11);

xn += n1;
xm -= n1;
}

TEST(rounding_scaled_integer, 991CmpTest)
{
using DecX_2 = cnl::scaled_integer<cnl::rounding_integer<long long>, cnl::power<-2, 10>>;

DecX_2 n1;
DecX_2 n2 = 10.019;
DecX_2 n3{20.029};
EXPECT_DOUBLE_EQ((double)n2, 10.02);
EXPECT_DOUBLE_EQ((double)n3, 20.03);

n1 = 3.999; //4.00 instead
n3 = DecX_2(8);
EXPECT_NE(n1, 3.9899999999999999999999999);
EXPECT_EQ(n1, 4.0000000000000000000000001);
EXPECT_EQ(n3, 8);
}
}