Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating parquet tools #182

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elferherrera
Copy link
Contributor

Updating parquet tools after the dictionary_page was removed from CompressedDataPage. Draft PR to follow up Issue #177

@codecov-commenter
Copy link

Codecov Report

Merging #182 (7e09056) into main (ba5ee69) will increase coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
+ Coverage   85.49%   85.63%   +0.14%     
==========================================
  Files          78       82       +4     
  Lines        7898     8089     +191     
==========================================
+ Hits         6752     6927     +175     
- Misses       1146     1162      +16     
Impacted Files Coverage Δ
src/schema/types/spec.rs 54.07% <0.00%> (-5.28%) ⬇️
src/write/stream.rs 86.77% <0.00%> (-2.97%) ⬇️
src/write/file.rs 90.75% <0.00%> (-2.19%) ⬇️
src/metadata/file_metadata.rs 85.71% <0.00%> (-1.43%) ⬇️
src/compression.rs 92.43% <0.00%> (-0.79%) ⬇️
src/encoding/hybrid_rle/mod.rs 98.31% <0.00%> (-0.04%) ⬇️
src/encoding/hybrid_rle/bitmap.rs 98.48% <0.00%> (-0.03%) ⬇️
src/encoding/hybrid_rle/encoder.rs 100.00% <0.00%> (ø)
src/encoding/delta_bitpacked/mod.rs 100.00% <0.00%> (ø)
src/encoding/delta_bitpacked/decoder.rs 99.22% <0.00%> (ø)
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@elferherrera
Copy link
Contributor Author

@jorgecarleitao I'm probably going to remove the struct PrimitivePageDict since we only need the values. However, as it is, I get the wrong decoded values for i64 and i32. I'm wondering if I'm missing something during the decoding stage.

@elferherrera elferherrera marked this pull request as draft August 15, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants