Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve deserialize API #192

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Improve deserialize API #192

wants to merge 8 commits into from

Conversation

jorgecarleitao
Copy link
Owner

This PR significantly expands the deserialize API to cover the possible variations of pages that exist.

The example demos how it can be used.

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2022

Codecov Report

Merging #192 (2deb916) into main (52756d1) will decrease coverage by 3.14%.
The diff coverage is 35.04%.

@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
- Coverage   85.64%   82.49%   -3.15%     
==========================================
  Files          84       86       +2     
  Lines        8248     8616     +368     
==========================================
+ Hits         7064     7108      +44     
- Misses       1184     1508     +324     
Impacted Files Coverage Δ
src/deserialize/integer.rs 0.00% <0.00%> (ø)
src/encoding/plain_byte_array.rs 84.00% <ø> (ø)
src/deserialize/binary.rs 13.63% <9.09%> (-61.37%) ⬇️
src/deserialize/native.rs 33.33% <20.00%> (-30.31%) ⬇️
src/deserialize/fixed_binary.rs 21.66% <21.66%> (ø)
src/deserialize/boolean.rs 27.02% <24.24%> (-45.20%) ⬇️
src/deserialize/utils.rs 65.45% <66.16%> (-24.21%) ⬇️
src/deserialize/values.rs 69.56% <69.56%> (ø)
src/deserialize/hybrid_rle.rs 38.37% <0.00%> (-22.10%) ⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants