Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Separate out recovery codes from TOTP #4707

Closed
ThisIsMani opened this issue May 20, 2024 · 0 comments · Fixed by #4708 or #4765
Closed

refactor: Separate out recovery codes from TOTP #4707

ThisIsMani opened this issue May 20, 2024 · 0 comments · Fixed by #4708 or #4765
Assignees

Comments

@ThisIsMani
Copy link
Contributor

Even though recovery codes is dependent entity on TOTP. But the new findings suggest that TOTP is a part of entity called 2FA and TOTP is depended on the 2FA entity not the TOTP entity.

This will be more clear when we add multiple 2FAs like SMS OTP.

So, we want to separate out recovery codes from the TOTP. This means begin_totp should not return the recovery codes anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant