feat(users): Create generate recovery codes API #4708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThisIsMani
added
C-feature
| @@ -68,8 +68,10 @@ pub enum UserErrors { | |||
| RoleNameAlreadyExists, | |||
| #[error("TOTPNotSetup")] | |||
There was a problem hiding this comment.
This also should be Totp considering below two
crates/router/src/core/user.rs
Outdated
| @@ -1631,7 +1631,7 @@ pub async fn begin_totp( | |||
| })); | |||
| } | |||
|
|
|||
| let totp = utils::user::generate_default_totp(user_from_db.get_email(), None)?; | |||
| let totp = utils::user::two_fa::generate_default_totp(user_from_db.get_email(), None)?; | |||
There was a problem hiding this comment.
It would be better if we call this function two_factor_authentication?
There was a problem hiding this comment.
It is a module and I feel it will be too big for a file name.
Opinions @racnan
apoorvdixit88
approved these changes
May 21, 2024
racnan
approved these changes
May 22, 2024
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Currently recovery code are being generated in
begin_totpAPI. We want to make a separate out recovery codes and TOTP, so this PR creates a new API which generates the recovery codes.This API will also be used to regenerate recovery codes later.
Additional Changes
Motivation and Context
This is a sub part of #4707
How did you test it?
This can only be tested locally as it requires some changes in the redis.
Checklist
cargo +nightly fmt --allcargo clippy