-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cypress): add pix payment method to adyen #4685
Conversation
c85ebd0
to
b5e27fd
Compare
"license": "ISC" | ||
"license": "ISC", | ||
"dependencies": { | ||
"jsqr": "^1.4.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dependency has been added intentionally and is used in line 770 of commands.js (fetchAndParseQRCode
) which is called in line 881 of commands.js just so that we can parse the QR the code and read the value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure this is inline with changes being done in the framework at #4624
cypress-tests/cypress/fixtures/bankTransfersConfirmBody/adyen-pix-confirm-body.json
Outdated
Show resolved
Hide resolved
b5e27fd
to
78f6a9c
Compare
}, | ||
"payment_method": "card", | ||
"payment_method_type": "credit", | ||
"payment_method_data": {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been made empty to allow bank_transfers to work. Have verified with cards, it does not harm them.
78f6a9c
to
6daf5f6
Compare
Closing in favour of #4766 |
Type of Change
Description
prettier
Flow:
Note
SDK says payment is
processing
, but on dashboard, even afterforce_psync
, the status remains asrequires_customer_action
.One would also need to login to Adyen dashboard and manually move the status from offer to sale to move the payment status to
processing
Adyen login is behind a 2FA
Additional Changes
Motivation and Context
NIL
How did you test it?
Checklist
cargo +nightly fmt --all
cargo clippy