feat(core): Create Payout Webhook Flow #4696
Open
+806
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakilmostak
added
A-core
kashif-m
reviewed
May 21, 2024
| pub fn is_payout_event(event_code: &WebhookEventCode) -> bool { | ||
| matches!( | ||
| event_code, | ||
| WebhookEventCode::PayoutThirdparty | WebhookEventCode::PayoutDecline |
There was a problem hiding this comment.
Are we not handling PAYOUT_REVERSED and PAYOUT_EXPIRE?
ref - https://docs.adyen.com/online-payments/online-payouts/payout-webhook/
There was a problem hiding this comment.
Added support for them
| Self::PayoutDetails(payout_payload) => Some(OutgoingWebhookEventContent::Payout { | ||
| payout_id: payout_payload.payout_id.clone(), | ||
| content: masking::masked_serialize(&payout_payload) | ||
| .unwrap_or(serde_json::json!({"error":"failed to serialize"})), |
There was a problem hiding this comment.
Is this what we send to merchants if deserialization fails?
crates/router/src/types.rs
Outdated
| @@ -420,7 +420,7 @@ impl PayoutIndividualDetailsExt for api_models::payouts::PayoutIndividualDetails | |||
| #[derive(Clone, Debug, Default)] | |||
| pub struct PayoutsResponseData { | |||
| pub status: Option<storage_enums::PayoutStatus>, | |||
| pub connector_payout_id: String, | |||
| pub connector_payout_id: Option<String>, | |||
There was a problem hiding this comment.
TODO for later: make it non optional, and add new struct for connector integration if this field is not consumed in other flows
| @@ -1107,6 +1108,10 @@ pub enum EventType { | |||
| DisputeLost, | |||
| MandateActive, | |||
| MandateRevoked, | |||
| PayoutSuccess, | |||
There was a problem hiding this comment.
Possible to add PayoutCreated? Trigger - when payout is created at connector's end.
| ) | ||
| .await | ||
| } | ||
| MerchantStorageScheme::RedisKv => { |
There was a problem hiding this comment.
@dracarys18 can you review the reverse lookup bit?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Create core flow for processing payout webhooks and send respective outgoing webhook
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy