-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(router): Added amount conversion function in core for connector module #4710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m/juspay/hyperswitch into change_core_amount_to_domain_type
…m/juspay/hyperswitch into change_core_amount_to_domain_type
…m/juspay/hyperswitch into change_core_amount_to_domain_type
…m/juspay/hyperswitch into change_core_amount_to_domain_type
…m/juspay/hyperswitch into change_core_amount_to_domain_type
Sakilmostak
previously approved these changes
May 30, 2024
Aprabhat19
previously approved these changes
May 30, 2024
jarnura
previously approved these changes
May 30, 2024
apoorvdixit88
previously approved these changes
May 30, 2024
Narayanbhat166
previously approved these changes
May 30, 2024
sahkal
dismissed stale reviews from Narayanbhat166, apoorvdixit88, jarnura, Aprabhat19, and Sakilmostak
via
May 30, 2024 12:45
ff4c9e9
Narayanbhat166
approved these changes
May 30, 2024
Aprabhat19
approved these changes
May 30, 2024
Sakilmostak
approved these changes
May 30, 2024
ThisIsMani
approved these changes
May 30, 2024
SamraatBansal
approved these changes
May 30, 2024
jarnura
approved these changes
May 30, 2024
apoorvdixit88
approved these changes
May 30, 2024
SanchithHegde
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-connector-integration
Area: Connector integration
A-core
Area: Core flows
A-currency-conversion
Area: Currency Conversion
A-payments
Area: payments
C-feature
Category: Feature request or enhancement
high-risk
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Currently while sending amount to connector, connector does the conversion for all the flows
with this change we will make the amount conversion function as a part of core, where connector will send core in what format it needs the data in and core will do the conversion and connector needs to execute convert function to get that converted data.
Additional Changes
Motivation and Context
How did you test it?
To Test this we can do a transaction with NMI and check NMI dashboard for the amount being sent.
note: NMI use currency as Major Unit
Flows to test :
Capture Call
Checklist
cargo +nightly fmt --all
cargo clippy