Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-10967): handle ima dai postroll #409

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(FEC-10967): handle ima dai postroll #409

wants to merge 1 commit into from

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Feb 3, 2021

Description of the Changes

Issue: Ima dai post-roll doesn't work with another ad.
Solution: handle playback ended and let ima dai work with another ad.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Yuvalke
fix: handle ima dai postroll
2f0d1ad 
Issue: Ima dai postroll doesn't work with another ad.
Solution: handle playback ended and let ima dai to work with another ad
@Yuvalke Yuvalke requested a review from a team February 3, 2021 08:58
@Yuvalke Yuvalke self-assigned this Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Yuvalke Yuvalke

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Yuvalke