Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-13166): add validation for tracks unsupported #809

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(FEC-13166): add validation for tracks unsupported #809

wants to merge 1 commit into from

Conversation

giladna
Copy link
Contributor

@giladna giladna commented May 19, 2023

Add: if (!isTypeSupportedTracks(tracks))

@giladna
add validation for tracks un supported
3ce6829 
        if (!isTypeSupportedTracks(tracks))
@giladna giladna temporarily deployed to Build May 19, 2023 04:14 — with GitHub Actions Inactive
@giladna giladna requested a review from OrenMe May 19, 2023 04:14
@giladna
Copy link
Contributor Author

giladna commented May 19, 2023 •
edited

@OrenMe I believe this is just extra validation as we check for support in the tracks creation
so not convinced 100% it is required but it is nice to have as exo player are also ding so

@giladna giladna changed the title fix(FEC-13166): add validation for tracks un supported fix(FEC-13166): add validation for tracks unsupported May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe Awaiting requested review from OrenMe

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@giladna