Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ExoPlayer 2.18.7 #810

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Upgrade ExoPlayer 2.18.7 #810

wants to merge 1 commit into from

Conversation

giladna
Copy link
Contributor

@giladna giladna commented Jun 14, 2023

Moved the drmSessionManager.setPlayer(playbackLooper, playbackPlayerId);
to class method setPlayer
due to new validation added in 2.18.6 (https://github.com/google/ExoPlayer/blob/ac9d5337b2b51a855f3c33f3b126d9ef921ebc69/library/core/src/main/java/com/google/android/exoplayer2/drm/DefaultDrmSessionManager.java#L471)

FEC-13228

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

Moved the       drmSessionManager.setPlayer(playbackLooper, playbackPlayerId);

to  class setPlayer
@giladna giladna temporarily deployed to Build June 14, 2023 15:21 — with GitHub Actions Inactive
@giladna giladna requested a review from OrenMe June 14, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant