Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: post seeking notification before initiating AVPlayer seek operation #476

Merged
merged 1 commit into from
May 29, 2024

Conversation

kononenkoAnton
Copy link
Contributor

Description of the Changes

Moved the 'seeking' notification to precede the initiation of the AVPlayer seek operation. This change aims to mitigate potential edge cases where the 'seeking' operation could be erroneously called after the 'seeked' notification, ensuring a more accurate sequence of event notifications.

In our release builds, we found a problem where sometimes the 'seeked' event happens before the 'seeking' event. This happens right after we set up the player and try to move to a 'continue watching' position. We couldn't see this issue when we were debugging, but looking closer at the Play-Kit code, we think the issue might be because of the order we send out notifications. This update fixes that by making sure we send the 'seeking' notification before we start the seek. This should stop the 'seeked' event from showing up too early.

Also question about in case failed, are you expecting to do seeked event or some new event seekFailed

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@kaltura-hooks
Copy link

Hi @kononenkoAnton,
Thank you for contributing this pull request!
Please sign the Kaltura CLA so we can review and merge your contribution.
Learn more at http://bit.ly/KalturaContrib

@x-NR-x
Copy link
Collaborator

x-NR-x commented Apr 8, 2024

Hi @kononenkoAnton,

Thank you for your contribution.
Regarding your question, I currently don't know of an additional events, but will check.

Thanks,
Nilit Danan

@imberezin imberezin merged commit 5212edd into kaltura:develop May 29, 2024
imberezin added a commit that referenced this pull request May 29, 2024
* develop:
  fix: post seeking notification before initiating AVPlayer seek operation (#476)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants