Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(FEC-12712) - add CSS examples #714

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

doc(FEC-12712) - add CSS examples #714

wants to merge 4 commits into from

Conversation

giladna
Copy link
Contributor

@giladna giladna commented Dec 21, 2022

Description of the Changes

FEC-12712

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

SivanA-Kaltura
SivanA-Kaltura requested changes Dec 21, 2022
View reviewed changes
docs/css-classes-override.md Outdated
```


* Modifing the elements can be done progrmatically in some more ways like querySelctor, gerElemetById and more
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modifying the inline style is something else and is more complicated. i dont think this in the scope of this explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SivanA-Kaltura SivanA-Kaltura SivanA-Kaltura requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@giladna @SivanA-Kaltura