Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove detached elements and remove not needed DOM refs #485

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: remove detached elements and remove not needed DOM refs #485

wants to merge 2 commits into from

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Sep 27, 2020

Description of the Changes

issue: element that doesn't exist on DOM and has ref doesn't clear by the garbage collector.
Solution: clear the refs and remove unneeded saved dom reference.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Yuvalke
fix: remove detached elements and remove not needed refs
75af6dd 
issue: element that doesn't exist on DOM and has ref doesn't clear by garbage collector.
Solution: clear the refs and remove uneeded saved dom reference
@Yuvalke Yuvalke requested a review from a team September 27, 2020 09:22
@Yuvalke Yuvalke self-assigned this Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Yuvalke Yuvalke

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Yuvalke