Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kokkos README's FENL link #6834

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

mhoemmen
Copy link
Contributor

FENL example lives in TrilinosCouplings now.

Copy link
Contributor

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to target develop.

@masterleinad
Copy link
Contributor

The alternative would be to just delete these lines, of course, since we don't have any control over the future (location) of this example anyway.

@cedricchevalier19
Copy link
Member

I think FENL example should also be listed in https://github.com/kokkos/kokkos-miniapps if this repo is still active.

@crtrott crtrott changed the base branch from master to develop February 27, 2024 16:48
@crtrott crtrott changed the base branch from develop to master February 27, 2024 16:48
@dalg24 dalg24 changed the base branch from master to develop May 22, 2024 14:05
@dalg24 dalg24 dismissed masterleinad’s stale review May 22, 2024 14:06

I retargeted develop

@dalg24 dalg24 requested a review from masterleinad May 22, 2024 14:06
@dalg24
Copy link
Member

dalg24 commented May 22, 2024

The format check passed. Ignoring everything else

@dalg24 dalg24 merged commit 6a3d918 into kokkos:develop May 22, 2024
0 of 2 checks passed
@mhoemmen mhoemmen deleted the fix-README-FENL-link branch May 28, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants