Test DualView resize/realloc with WithoutInitializing for types without default constructor #7006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
force-pushed
the
test_no_default_constructor_dualview
branch
from
cd43473
to
cadab6c
Compare
cedricchevalier19
approved these changes
May 15, 2024
Comment on lines
+497
to
+498
| Impl::test_dualview_realloc<NoDefaultConstructor, TEST_EXECSPACE, | ||
| /* Initialize */ false>(); |
There was a problem hiding this comment.
A little bit disturbing to have Impl:: on this line and not on the one above.
There was a problem hiding this comment.
test_dualview_realloc calls Impl::test_dualview_realloc both with Initialiize=true and Initialize=false. We can only test with Initialize=false for NoDefualtConstructor, though.
Comment on lines
+503
to
+504
| Impl::test_dualview_resize<NoDefaultConstructor, TEST_EXECSPACE, | ||
| /* Initialize */ false>(); |
There was a problem hiding this comment.
A little bit disturbing to have Impl:: on this line and not on the one above.
crtrott
approved these changes
May 16, 2024
crtrott
requested changes
May 16, 2024
masterleinad
force-pushed
the
test_no_default_constructor_dualview
branch
from
9b0d839
to
c07e218
Compare
masterleinad
force-pushed
the
test_no_default_constructor_dualview
branch
from
c07e218
to
2b7b98a
Compare
|
Retest this please |
crtrott
approved these changes
May 23, 2024
crtrott
requested changes
May 23, 2024
No,
was fixed in a different pull request and this one only modifies container tests anyway. |
crtrott
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds another test for
DualViewfor #6993 that fixedKokkos::realloc/resizewith Kokkos::WithouttInitializing such that it can be used with types that don't define a default constructor.