HPCBIND: Prevent hwloc-ls from opening graphic windows unintentionally #7010
Conversation
| @@ -635,7 +635,9 @@ if [[ ${HPCBIND_TEE} -eq 0 || ${HPCBIND_VERBOSE} -eq 0 ]]; then | |||
|
|
|||
| if [[ ${HPCBIND_HAS_HWLOC} -eq 1 ]]; then | |||
| echo "[BINDINGS]" >> ${HPCBIND_LOG} | |||
| hwloc-ls --restrict "${HPCBIND_HWLOC_CPUSET}" >> ${HPCBIND_LOG} | |||
| if [[ ${HPCBIND_LSTOPO} -eq 1 && ! -z ${DISPLAY} ]]; then | |||
| hwloc-ls --restrict "${HPCBIND_HWLOC_CPUSET}" >> ${HPCBIND_LOG} | |||
There was a problem hiding this comment.
Would passing --output-format console resolve your issue?
(I have no experience with hpcbind nor hwloc)
| @@ -635,7 +635,9 @@ if [[ ${HPCBIND_TEE} -eq 0 || ${HPCBIND_VERBOSE} -eq 0 ]]; then | |||
|
|
|||
| if [[ ${HPCBIND_HAS_HWLOC} -eq 1 ]]; then | |||
| echo "[BINDINGS]" >> ${HPCBIND_LOG} | |||
| hwloc-ls --restrict "${HPCBIND_HWLOC_CPUSET}" >> ${HPCBIND_LOG} | |||
| if [[ ${HPCBIND_LSTOPO} -eq 1 && ! -z ${DISPLAY} ]]; then | |||
| hwloc-ls --restrict "${HPCBIND_HWLOC_CPUSET}" >> ${HPCBIND_LOG} | |||
There was a problem hiding this comment.
Isn't $DISPLAY set / unset on the user's machine? Assuming that's the case, then conditioning hwloc-ls --restrict "${HPCBIND_HWLOC_CPUSET}" >> ${HPCBIND_LOG} upon ${DISPLAY} being non zero (if it's set at all) could have negative downstream effects for users who wish to use hpcbind , but do not have $DISPLAY set. I checked a couple of (non-Windows) machines, and $DISPLAY wasn't set, appearing to be the default scenario. Would it be possible for you to simply unset $DISPLAY before using hpcbind?
| hwloc-ls --restrict "${HPCBIND_HWLOC_CPUSET}" --no-io --no-bridges > >(tee -a ${HPCBIND_LOG}) | ||
| if [[ ${HPCBIND_LSTOPO} -eq 1 && ! -z ${DISPLAY} ]]; then | ||
| hwloc-ls --restrict "${HPCBIND_HWLOC_CPUSET}" --no-io --no-bridges > >(tee -a ${HPCBIND_LOG}) | ||
| fi |
There was a problem hiding this comment.
See comment above above the logic and potential risk of the proposed change.
I noticed that
hpcbindunconditionally opens two lstopo X windows when a display is present. The command I ran to trigger this behavior washpcbind --distribute=2 --distribute-partition=1 -vin combination with hwloc version 2.7.0 on ubuntu 22.04 lts.
This PR changes this behavior to only open these windows when the
--lstopoflag is passed at the command line.