Always run Graph tests #7011
Merged
Always run Graph tests #7011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,5 +23,6 @@ | |||
| #define TEST_CATEGORY_NUMBER 7 | |||
| #define TEST_CATEGORY_DEATH sycl_DeathTest | |||
| #define TEST_EXECSPACE Kokkos::Experimental::SYCL | |||
| #define TEST_CATEGORY_FIXTURE(name) sycl_##name | |||
There was a problem hiding this comment.
Just a suggestion:
#define TEST_CATEGORY_FIXTURE(name) sycl_##name
#define TEST_CATEGORY_DEATH TEST_CATEGORY_FIXTURE(DeathTest)There was a problem hiding this comment.
I would rather not since that would suggest mixing macros defined for fixtures with death tests that don't require fixtures.
dalg24
reviewed
May 17, 2024
| #endif | ||
| graph.submit(); // should reset to 0, but doesn't | ||
| graph.submit(); |
There was a problem hiding this comment.
Why is it ok to remove that comment?
There was a problem hiding this comment.
It didn't make sense to me. The submission is resetting to zero and that's what we are testing.
core/unit_test/TestGraph.hpp
Outdated
| Kokkos::fence(); | ||
| if constexpr (std::is_same_v<TEST_EXECSPACE, Kokkos::Cuda>) Kokkos::fence(); | ||
| #endif | ||
| // FIXME_HPX graph.submit() isn't properly enqueued |
There was a problem hiding this comment.
Nitpick: I would have put the comment on the same line as the #ifdef (if that fits without breaking the line)
dalg24
approved these changes
May 20, 2024
crtrott
approved these changes
May 20, 2024
|
It looks like we were careless when we merged this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't have a specialization for the Graph implementation, kernels are just executed in order. Hence, we should always be able to test the Graph implementation and don't need to create separate executables which brings the test more inline with our general testing approach (by auto-generating the test files for individual backends).
Related to #6912.