Add ProvReq annotations to the api package

[yaroslava-serdiuk]

What type of PR is this?

/kind cleanup

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yaroslava-serdiuk
Once this PR has been reviewed and has the lgtm label, please assign feiskyer for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• cluster-autoscaler/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tenzen-y]

Thank you for doing this!
I guess that we should remove existing annotations

autoscaler/cluster-autoscaler/provisioningrequest/pods/pods.go

Lines 30 to 35 in 0c26da3

	const (
	// ProvisioningRequestPodAnnotationKey is a key used to annotate pods consuming provisioning request.
	ProvisioningRequestPodAnnotationKey = "cluster-autoscaler.kubernetes.io/consume-provisioning-request"
	// ProvisioningClassPodAnnotationKey is a key used to add annotation about Provisioning Class
	ProvisioningClassPodAnnotationKey = "cluster-autoscaler.kubernetes.io/provisioning-class-name"
	)

, right?

[towca]

Hmm, @MaciekPytel we probably want x-k8s.io instead of kubernetes.io here as well, right? @yaroslava-serdiuk there aren't any pods in the wild using these annotations yet, right?

[MaciekPytel]

Agreed, it is completely inconsistent with the rest of the names in this API. If there are any pods using it already, we may need to do a deprecation where we support both for a while, but we need to be consistent with those APIs.

If it's just a cluster autoscaler API, we should put cluster autoscaler in API group and everywhere else. If it's kubernetes API, than it shouldn't use annotation that specifically refers to CA

[yaroslava-serdiuk]

Do you mean we need to have "autoscaling.x-k8s.io/consume-provisioning-request"?

[x13n]

Assigning since looks like you're reviewing this one already.

/assign @towca

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tenzen-y]

@yaroslava-serdiuk What is the reason that this PR was closed? Does this mean that these annotations are never exposed via API module?

[yaroslava-serdiuk]

@tenzen-y My understanding is that the API module should include annotations with autoscaling prefix and just replacing annotations will break already working things.