-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GCE client long polling timeouts. #6783
base: master
Are you sure you want to change the base?
Conversation
Hi @mtrqq. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign x13n |
62b8460
to
fe9f34c
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mtrqq The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a minor comment.
/ok-to-test |
fe9f34c
to
ae3ef4b
Compare
What type of PR is this?
/kind bug
/kind regression
What this PR does / why we need it:
At the moment GCE manager is using 30 seconds timeouts for all http calls which breaks logic of long polling WAIT calls for GCE API as in the worst case scenario they require 2 minutes.
This PR increases http timeout to be 3 minutes (2 minutes + buffer time) and adds timeouts control over some operations in order to avoid performance degradation in the case of not responding API. Not all the methods can be patched, as with pagination we are not sure what would be the exact number of calls and current GCE API doesn't provide a way to control per call timeouts.
Special notes for your reviewer:
gce.New
to usegce.NewService
http.Client.Timeout
affects operation callsDoes this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: