Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GCE client long polling timeouts. #6783

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mtrqq
Copy link
Contributor

@mtrqq mtrqq commented Apr 30, 2024

What type of PR is this?

/kind bug
/kind regression

What this PR does / why we need it:

At the moment GCE manager is using 30 seconds timeouts for all http calls which breaks logic of long polling WAIT calls for GCE API as in the worst case scenario they require 2 minutes.

This PR increases http timeout to be 3 minutes (2 minutes + buffer time) and adds timeouts control over some operations in order to avoid performance degradation in the case of not responding API. Not all the methods can be patched, as with pagination we are not sure what would be the exact number of calls and current GCE API doesn't provide a way to control per call timeouts.

Special notes for your reviewer:

  • This PR also changes deprecated method gce.New to use gce.NewService
  • Wait operation doesn't have an extra handling for per operation calls as it adds significant complexity to the method, it relies on the 3 minute http client timeout
  • I've also conducted manual test that http.Client.Timeout affects operation calls

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 30, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @mtrqq. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 30, 2024
@mtrqq
Copy link
Contributor Author

mtrqq commented Apr 30, 2024

/assign x13n

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mtrqq
Once this PR has been reviewed and has the lgtm label, please ask for approval from x13n. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@x13n x13n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a minor comment.

@x13n
Copy link
Member

x13n commented May 2, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 2, 2024
@mtrqq mtrqq force-pushed the fix/gce-http-client-timeouts branch from fe9f34c to ae3ef4b Compare May 6, 2024 11:53
@mtrqq mtrqq requested a review from x13n May 6, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-autoscaler area/provider/gce cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants