chore(deps): update vendored hcloud-go to 2.8.0 #6797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by: ``` UPSTREAM_REF=v2.8.0 hack/update-vendor.sh ```
I have to agree with the removed comment, the previous interface was very weird to hold. hcloud-go 2.8.0 introduced a new `WaitFor()` interface that simplifies this a lot. The custom handler is no longer required.
k8s-ci-robot
added
kind/cleanup
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apricote The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/cluster-autoscaler
cncf-cla: yes
|
Thanks @apricote |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/area provider/hetzner
What this PR does / why we need it:
Update hcloud-go from 2.4.0 to 2.8.0
Generated by:
Replace the custom method
waitForServerActionwith the upstreamActionClient.WaitForwhich was introduced in 2.8.0.Which issue(s) this PR fixes:
Special notes for your reviewer:
The first commit only updates the vendored version of
hcloud-go. The second replaces the custom method. Happy to split this into two PRs if requested.Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: