-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature toggle for custom error pages /metrics #10984
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @ricardoapl! |
Hi @ricardoapl. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is still missing changes to the Helm chart, but I would really appreciate some feedback before the implementation is complete |
/assign @tao12345666333 |
/ok-to-test |
@tao12345666333 @strongjz please take another look, I believe I have resolved all of the issues |
Thanks! I will have a test today. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ricardoapl The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Ricardo Lopes <ricardoapl.dev@gmail.com>
Signed-off-by: Ricardo Lopes <ricardoapl.dev@gmail.com>
Signed-off-by: Ricardo Lopes <ricardoapl.dev@gmail.com>
Signed-off-by: Ricardo Lopes <ricardoapl.dev@gmail.com>
Signed-off-by: Ricardo Lopes <ricardoapl.dev@gmail.com>
Signed-off-by: Ricardo Lopes <ricardoapl.dev@gmail.com>
Signed-off-by: Ricardo Lopes <ricardoapl.dev@gmail.com>
Signed-off-by: Ricardo Lopes <ricardoapl.dev@gmail.com>
Signed-off-by: Ricardo Lopes <ricardoapl.dev@gmail.com>
Signed-off-by: Ricardo Lopes <ricardoapl.dev@gmail.com>
4e69af7
to
86e89ed
Compare
I have re-run the |
Thank you @tao12345666333, I believe I have made a mistake in the Helm chart unit tests -- I will fix that I will also try to add an e2e test for these changes as suggested by @strongjz on Slack |
Signed-off-by: Ricardo Lopes <ricardoapl.dev@gmail.com>
86e89ed
to
67a87c4
Compare
50115ac
to
6c9faf0
Compare
Signed-off-by: Ricardo Lopes <ricardoapl.dev@gmail.com>
Signed-off-by: Ricardo Lopes <ricardoapl.dev@gmail.com>
Signed-off-by: Ricardo Lopes <ricardoapl.dev@gmail.com>
859e4d8
to
6d2f8d0
Compare
I have fixed the Helm chart unit tests and added e2e tests as well Please take another look @tao12345666333 |
What this PR does / why we need it:
Adds feature toggle to expose /metrics and /debug/vars endpoints from custom error pages default backend
Types of changes
Which issue/s this PR fixes
Fixes #9152
How Has This Been Tested?
Tested manually on local machine by running the binary with different environment variable combinations such as
Checklist: