Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotations: Drop SSLv2, SSLv3, TLSv1 & TLSv1.1 support. #11343

Merged
merged 1 commit into from
May 28, 2024
Merged

Annotations: Drop SSLv2, SSLv3, TLSv1 & TLSv1.1 support. #11343

merged 1 commit into from
May 28, 2024

Conversation

longwuyuan
Copy link
Contributor

What this PR does / why we need it:

  • TLSv1 & TLSv1.1 support was removed earlier
  • There were some lingering strings for these deprecated tls protocols in the code
  • This PRs attempts to remove any remaining traces of these deprecated protocols

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

fixes #8633

How Has This Been Tested?

  • Manually tried to use tlsv1 with curl but that is just to confirm existing deprecation
  • Otherwise no testing needed as its a cosmetic chage

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

cc @tao12345666333 @rikatz

/kind bug
/triage accepted
/priority backlog

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 4, 2024
@netlify Netlify
Copy link

netlify bot commented May 4, 2024 •
edited

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit 2314436
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/665430c37c3c0700088be147

@longwuyuan
Copy link
Contributor Author

@tao12345666333 @rikatz Kindly review/approve

@longwuyuan
Copy link
Contributor Author

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 4, 2024
@longwuyuan longwuyuan force-pushed the remove-deprecated-tls-versions branch 3 times, most recently from 7c3df0f to 7cab3c2 Compare May 4, 2024 13:17
@longwuyuan longwuyuan force-pushed the remove-deprecated-tls-versions branch from 7cab3c2 to 55484e5 Compare May 4, 2024 16:53
@longwuyuan
Copy link
Contributor Author

/retest

@longwuyuan
Copy link
Contributor Author

/test pull-ingress-nginx-codegen

@longwuyuan longwuyuan force-pushed the remove-deprecated-tls-versions branch 2 times, most recently from 5ac5ab6 to d2791ee Compare May 6, 2024 07:41
@longwuyuan
Copy link
Contributor Author

I could not figure out the reason for this error so need to dig deep now. Any help appreciated
image

That line 146 in Makefile is the run-in-docker-script
image

@tao12345666333 please point me in a direction to search for root-cause here, when you get a chance

@longwuyuan
Copy link
Contributor Author

/retest

@longwuyuan longwuyuan force-pushed the remove-deprecated-tls-versions branch from d2791ee to 2314436 Compare May 27, 2024 07:05
Gacko
Gacko approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@Gacko Gacko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retitle Annotations: Drop SSLv2, SSLv3, TLSv1 & TLSv1.1 support.
/lgtm

@k8s-ci-robot k8s-ci-robot changed the title removed tlsv1 & tlsv1.1 Annotations: Drop SSLv2, SSLv3, TLSv1 & TLSv1.1 support. May 28, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, longwuyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5639979 into kubernetes:main May 28, 2024
27 checks passed
@longwuyuan longwuyuan deleted the remove-deprecated-tls-versions branch May 28, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao12345666333 tao12345666333 tao12345666333 left review comments

@Gacko Gacko Gacko approved these changes

@puerco puerco Awaiting requested review from puerco

Assignees

@Gacko Gacko

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/docs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate TLS v1.0, TLS v1.1 and SSLv3
4 participants
@longwuyuan @k8s-ci-robot @Gacko @tao12345666333