[main] Fix drop-in dir logic explaination #46360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
sig/docs
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@kubernetes/sig-node-pr-reviews Would it be possible to get a quick tech review on this? |
k8s-ci-robot
added
the
sig/node
matthyx
reviewed
May 14, 2024
content/en/docs/tasks/administer-cluster/kubelet-config-file.md
Outdated
Show resolved
Hide resolved
sohankunkerkar
force-pushed
the
fix-drop-in-dir-docs
branch
from
3ae034b
to
007ba4e
Compare
carlory
reviewed
May 15, 2024
content/en/docs/tasks/administer-cluster/kubelet-config-file.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>
sohankunkerkar
force-pushed
the
fix-drop-in-dir-docs
branch
from
007ba4e
to
e823cf9
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 0c3074d20945336183f68d3b275882b92e65aacd
|
saschagrunert
approved these changes
May 17, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dipesh-rawat, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes kubernetes/kubernetes#124796
The current behavior of the drop-in directory merging logic is not properly documented. Ideally, Validation is performed on each drop-in configuration file before merging it into the final configuration structure stored internally by the kubelet.