-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Fix drop-in dir logic explaination #46360
[main] Fix drop-in dir logic explaination #46360
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@kubernetes/sig-node-pr-reviews Would it be possible to get a quick tech review on this? |
content/en/docs/tasks/administer-cluster/kubelet-config-file.md
Outdated
Show resolved
Hide resolved
3ae034b
to
007ba4e
Compare
content/en/docs/tasks/administer-cluster/kubelet-config-file.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>
007ba4e
to
e823cf9
Compare
/lgtm |
LGTM label has been added. Git tree hash: 0c3074d20945336183f68d3b275882b92e65aacd
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dipesh-rawat, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes kubernetes/kubernetes#124796
The current behavior of the drop-in directory merging logic is not properly documented. Ideally, Validation is performed on each drop-in configuration file before merging it into the final configuration structure stored internally by the kubelet.